Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 8375033: Fix wrong detection of duplicate definition of function types (issue 187). (Closed)

Created:
9 years, 2 months ago by regis
Modified:
9 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix wrong detection of duplicate definition of function types (issue 187). Duplicate import of a function type alias must be detected, but duplicate import of a compiler generated canonical function type is necessary for proper class resolution and is permitted. Add tests. Committed: https://code.google.com/p/dart/source/detail?r=658

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -47 lines) Patch
M runtime/vm/object.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 6 chunks +24 lines, -11 lines 0 comments Download
M runtime/vm/object_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 4 chunks +30 lines, -32 lines 0 comments Download
A tests/language/src/Library5NegativeTest.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/language/src/Library5Test.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A tests/language/src/Library5a.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A tests/language/src/Library5b.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A tests/language/src/Library6NegativeTest.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
9 years, 2 months ago (2011-10-24 20:53:23 UTC) #1
siva
LGTM. I would add one more negative test to the mix to confirm that we ...
9 years, 2 months ago (2011-10-24 22:19:03 UTC) #2
regis
9 years, 2 months ago (2011-10-24 22:27:20 UTC) #3
On 2011/10/24 22:19:03, asiva wrote:
> LGTM.
> 
> I would add one more negative test to the mix to confirm
> that we do the right lookup when adding function alias
> type names.
> 
> e.g Library6NegativeTest.dart
> #import("Library5a.dart");
> typedef int Fun();  // Expect this to conflict during parse.
> main() {
> }

Done

Powered by Google App Engine
This is Rietveld 408576698