Bleeding edge change to get frog integrated into the testing infrastructure.

Bleeding edge change to get frog integrated into the testing infrastructure.
Committed: https://code.google.com/p/dart/source/detail?r=1140

[ahe, 2011-11-03 11:18:37]

LGTM, nice work!

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.status
File dart/tests/corelib/corelib.status (right):

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:33: # VM or DartC specific tests not to be run
by Frog. See language.status
End sentence with a period.

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:39: ConstList*: Fail # const not currently
checked
Not proper sentence.

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:42: DoubleCompareTest: Fail # issue with
static finals and -Infinity, -0
Ditto.

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:62: StringTest: Fail  # needs index out of
range checks
Ditto.

http://codereview.chromium.org/8372095/diff/1/dart/tests/language/language.st...
File dart/tests/language/language.status (right):

http://codereview.chromium.org/8372095/diff/1/dart/tests/language/language.st...
dart/tests/language/language.status:184: PrivateMemberTest/01: Skip  # leads to
stack overflows when self-hosted
Proper sentence.

http://codereview.chromium.org/8372095/diff/1/dart/tests/language/language.st...
dart/tests/language/language.status:184: PrivateMemberTest/01: Skip  # leads to
stack overflows when self-hosted
Mark as crash?

http://codereview.chromium.org/8372095/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

http://codereview.chromium.org/8372095/diff/1/dart/tools/utils.py#newcode111
dart/tools/utils.py:111: def GetDart(mode, arch, component):
Please use proper python doc strings.

Also, consider if this method should be renamed to GetDartRunner or
GetDartRuntime.

[ngeoffray, 2011-11-03 11:53:00]

Thank you!

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.status
File dart/tests/corelib/corelib.status (right):

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:33: # VM or DartC specific tests not to be run
by Frog. See language.status
On 2011/11/03 11:18:38, ahe wrote:
> End sentence with a period.

These lines were copy pasted from frog/tests/frog.status. But I'll fix the
typos.

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:39: ConstList*: Fail # const not currently
checked
On 2011/11/03 11:18:38, ahe wrote:
> Not proper sentence.

Done.

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:42: DoubleCompareTest: Fail # issue with
static finals and -Infinity, -0
On 2011/11/03 11:18:38, ahe wrote:
> Ditto.

Done.

http://codereview.chromium.org/8372095/diff/1/dart/tests/corelib/corelib.stat...
dart/tests/corelib/corelib.status:62: StringTest: Fail  # needs index out of
range checks
On 2011/11/03 11:18:38, ahe wrote:
> Ditto.

Done.

http://codereview.chromium.org/8372095/diff/1/dart/tests/language/language.st...
File dart/tests/language/language.status (right):

http://codereview.chromium.org/8372095/diff/1/dart/tests/language/language.st...
dart/tests/language/language.status:184: PrivateMemberTest/01: Skip  # leads to
stack overflows when self-hosted
On 2011/11/03 11:18:38, ahe wrote:
> Proper sentence.

Done.

http://codereview.chromium.org/8372095/diff/1/dart/tests/language/language.st...
dart/tests/language/language.status:184: PrivateMemberTest/01: Skip  # leads to
stack overflows when self-hosted
On 2011/11/03 11:18:38, ahe wrote:
> Mark as crash?

This is copy/pasted lines. I won't change the outcome.

http://codereview.chromium.org/8372095/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

http://codereview.chromium.org/8372095/diff/1/dart/tools/utils.py#newcode111
dart/tools/utils.py:111: def GetDart(mode, arch, component):
On 2011/11/03 11:18:38, ahe wrote:
> Please use proper python doc strings.
> 

I followed the style in this script.

> Also, consider if this method should be renamed to GetDartRunner or
> GetDartRuntime.

Renamed to GetDartRunner.

[ngeoffray, 2011-11-03 12:15:21]

Submitting without the .gyp change to make sure it does not break the bots.