Issue 8372094: Renaming Array -> List in the VM API.

Issue 8372094: Renaming Array -> List in the VM API. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Renaming Array -> List in the VM API. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1195

Patch Set 3 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -122 lines)			Patch
M	runtime/bin/file.cc	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/bin/main.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/process.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/socket.cc	View	1 2	4 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 2	1 chunk	+34 lines, -41 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	12 chunks	+37 lines, -37 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	3 chunks	+27 lines, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

turnidge

LGTM with a couple of comments. http://codereview.chromium.org/8372094/diff/2001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): http://codereview.chromium.org/8372094/diff/2001/runtime/include/dart_api.h#newcode817 runtime/include/dart_api.h:817: DART_EXPORT Dart_Handle Dart_ListGet(Dart_Handle ...

9 years, 1 month ago (2011-11-03 17:45:40 UTC) #2

Mads Ager (google)

http://codereview.chromium.org/8372094/diff/2001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): http://codereview.chromium.org/8372094/diff/2001/runtime/include/dart_api.h#newcode817 runtime/include/dart_api.h:817: DART_EXPORT Dart_Handle Dart_ListGet(Dart_Handle list, On 2011/11/03 17:45:40, turnidge wrote: ...

9 years, 1 month ago (2011-11-04 11:20:50 UTC) #3

LGTM

Expand Messages | Collapse Messages