Issue 8371016: Fix infinite recursion when dealing with cyclic library dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8371016: Fix infinite recursion when dealing with cyclic library dependencies. (Closed)

Created:
9 years, 2 months ago by siva

Modified:
9 years, 1 month ago

Reviewers:
Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Fix infinite recursion when dealing with cyclic library dependencies. Committed: https://code.google.com/p/dart/source/detail?r=714

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -3 lines)			Patch
M	bin/file.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	bin/file_linux.cc	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	bin/file_macos.cc	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	bin/file_win.cc	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	bin/main.cc	View	1 2 3	4 chunks	+15 lines, -2 lines	0 comments	Download
M	bin/process_script.cc	View	1 2 3	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Mads Ager (google)

LGTM Could we add a regression test for this and implement on Windows?

9 years, 2 months ago (2011-10-25 05:59:47 UTC) #2

siva

A regression test for this has already been submitted it is in tests/language/src/CyclicImportTest.dart. I have ...

9 years, 2 months ago (2011-10-25 20:44:27 UTC) #3

Dan Rice

9 years, 1 month ago (2011-10-27 16:20:14 UTC) #4

This CL causes dart to die with a Bus Error on my machine (Mac OS X 10.5.8)