Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 8363044: Only call the dataReceived callback for sockets if there is actually data available (Closed)

Created:
9 years, 1 month ago by Søren Gjesse
Modified:
9 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Only call the dataReceived callback for sockets if there is actually data available R=ager@google.com BUG= TEST=EchoServerStreamTest.dart Committed: https://code.google.com/p/dart/source/detail?r=809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M runtime/bin/socket_impl.dart View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years, 1 month ago (2011-10-27 09:47:24 UTC) #1
Mads Ager (google)
9 years, 1 month ago (2011-10-27 10:05:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698