Igonre closure classes when looking for duplication.

Igonre closure classes when looking for duplication.
Committed: https://code.google.com/p/dart/source/detail?r=598

[Anton Muhin, 2011-10-21 12:24:00]

Sorry, no tests, just want to get rid of redness first.

This fixes the problem very similar to one reported by Soeren and Peter.

[Anton Muhin, 2011-10-21 12:24:00]

Sorry, no tests, just want to get rid of redness first.

This fixes the problem very similar to one reported by Soeren and Peter.

[Søren Gjesse, 2011-10-21 12:34:13]

lgtm - if you add a test to dart_api_impl_test.cc like the other ImportLibrary1X
tests

One script with

#import("lib.dart");
interface Y {
  void set handler(void callback(List<int> x));
}
void main() { }

and another with

#library("lib.dart");
interface X {
  void set handler(void callback(List<int> x));
}

should fail without this change and pass with it.

[Anton Muhin, 2011-10-21 12:46:24]

Test added.  Thanks a lot for review, Søren

Siva, sorry, I am submitting as is to unbreak build.  But, please, revert if
it's a wrong fix.

[Søren Gjesse, 2011-10-21 12:46:26]

lgtm

[siva, 2011-10-21 17:20:47]

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:1693: }
I would also add a test case where we except an error from signature classes
like the case I describe in the next file.

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:3711: }
I think this is not the right fix, imagine the case:
library1.dart has
typedef void callBackType(int param1, int param2);
and
library2.dart has
typedef int callBackType();

now we import these two into an app as
import library1.dart
import library2.dart
then we should get a duplicate definition error.

With this change I think we won't get an error.

[Anton Muhin, 2011-10-21 17:34:25]

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:3711: }
Thanks a lot, Siva.  Sounds like you're right.  I'll investigate if you don't
mind.

On 2011/10/21 17:20:47, asiva wrote:
> I think this is not the right fix, imagine the case:
> library1.dart has
> typedef void callBackType(int param1, int param2);
> and
> library2.dart has
> typedef int callBackType();
> 
> now we import these two into an app as
> import library1.dart
> import library2.dart
> then we should get a duplicate definition error.
> 
> With this change I think we won't get an error.

[siva, 2011-10-21 18:13:37]

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8363027/diff/4002/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:3711: }
Anton, see the updates done in issue 187. Regis and I were discussing this and
we concluded that the implicit signature classes were being added at the wrong
place.

On 2011/10/21 17:34:26, antonmuhin wrote:
> Thanks a lot, Siva.  Sounds like you're right.  I'll investigate if you don't
> mind.
> 
> On 2011/10/21 17:20:47, asiva wrote:
> > I think this is not the right fix, imagine the case:
> > library1.dart has
> > typedef void callBackType(int param1, int param2);
> > and
> > library2.dart has
> > typedef int callBackType();
> > 
> > now we import these two into an app as
> > import library1.dart
> > import library2.dart
> > then we should get a duplicate definition error.
> > 
> > With this change I think we won't get an error.
>