Issue 8361032: Use generated tests if dartc is not available.

Issue 8361032: Use generated tests if dartc is not available. (Closed)

Created:
9 years, 2 months ago by Ben Laurie (Google)

Modified:
9 years, 2 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Committed: https://code.google.com/p/dart/source/detail?r=600

Patch Set 4 : '' #

Total comments: 4

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+738 lines, -8 lines)			Patch
M	tests/stub-generator/src/MintMakerFullyIsolatedTest.dart	View	1 2	1 chunk	+1 line, -0 lines	2 comments	Download
A	tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart	View		1 chunk	+463 lines, -0 lines	0 comments	Download
A	tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart	View		1 chunk	+264 lines, -0 lines	0 comments	Download
M	tests/stub-generator/stub-generator.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/stub-generator/testcfg.py	View	1 2 3	5 chunks	+10 lines, -7 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. http://codereview.chromium.org/8361032/diff/5001/tests/stub-generator/src/MintMakerFullyIsolatedTest.dart File tests/stub-generator/src/MintMakerFullyIsolatedTest.dart (right): http://codereview.chromium.org/8361032/diff/5001/tests/stub-generator/src/MintMakerFullyIsolatedTest.dart#newcode237 tests/stub-generator/src/MintMakerFullyIsolatedTest.dart:237: //runTests([MintMakerFullyIsolatedTest.testMain]); If you are sure you will work ...

9 years, 2 months ago (2011-10-21 13:47:39 UTC) #3

Ben Laurie (Google)

9 years, 2 months ago (2011-10-21 13:56:58 UTC) #4

http://codereview.chromium.org/8361032/diff/5001/tests/stub-generator/src/Min...
File tests/stub-generator/src/MintMakerFullyIsolatedTest.dart (right):

http://codereview.chromium.org/8361032/diff/5001/tests/stub-generator/src/Min...
tests/stub-generator/src/MintMakerFullyIsolatedTest.dart:237:
//runTests([MintMakerFullyIsolatedTest.testMain]);
On 2011/10/21 13:47:39, floitsch wrote:
> If you are sure you will work on this in the near future, I'm ok with keeping
> the commented code, but put at least a TODO here. (and add a space after //).

I am going to do this shortly, but I removed it anyway.

http://codereview.chromium.org/8361032/diff/5001/tests/stub-generator/testcfg.py
File tests/stub-generator/testcfg.py (right):

http://codereview.chromium.org/8361032/diff/5001/tests/stub-generator/testcfg...
tests/stub-generator/testcfg.py:91: if self.context.generate ==
f.endswith('-generatedTest.dart'):
On 2011/10/21 13:47:39, floitsch wrote:
> This needs a comment.

Done.

Expand Messages | Collapse Messages