Issue 8361017: Fix intermittent simarm build breakage on macos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8361017: Fix intermittent simarm build breakage on macos. (Closed)

Created:
9 years, 2 months ago by siva

Modified:
9 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Description

Fix intermittent simarm build breakage on macos. cc1plus: warnings being treated as errors ./vm/object.h: In static member function 'static dart::RawString* dart::ClassFinalizer::FinalizeTypeWhileParsing(const dart::Type&)': ./vm/object.h:274: warning: variable 'this' might be clobbered by 'longjmp' or 'vfork' Committed: https://code.google.com/p/dart/source/detail?r=591

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	vm/class_finalizer.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages