Issue 8360027: Proper string comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8360027: Proper string comparison. (Closed)

Created:
9 years, 2 months ago by Anton Muhin

Modified:
9 years, 2 months ago

Reviewers:
cshapiro, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Proper string comparison. Committed: https://code.google.com/p/dart/source/detail?r=646

Patch Set 3 : Addressing comments #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/object.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/object_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Great catch! Can you please add a test case? Thanks, -Ivan

9 years, 2 months ago (2011-10-21 17:00:53 UTC) #2

cshapiro

http://codereview.chromium.org/8360027/diff/4001/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/8360027/diff/4001/runtime/vm/object.cc#newcode5347 runtime/vm/object.cc:5347: return str[0] == '\0'; How about "*str == '\0'" ...

9 years, 2 months ago (2011-10-21 20:12:47 UTC) #4

Anton Muhin

9 years, 2 months ago (2011-10-24 15:59:34 UTC) #5

lgtm

Expand Messages | Collapse Messages

Issue 8360027: Proper string comparison. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Test added. #

Patch Set 3 : Addressing comments #

Messages