Move the individual property definitions from client/base/Css to CSSStyleDeclaration.

Move the individual property definitions from client/base/Css to CSSStyleDeclaration.

Committed: https://code.google.com/p/dart/source/detail?r=651

[Jacob, 2011-10-21 17:12:23]

Looks very good.  Some minor comments.
Also, be sure to rerun the tests and add a simple test for CSSStyleDeclaration

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
File client/base/scripts/css_code_generator.py (left):

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
client/base/scripts/css_code_generator.py:5: # BSD-style license that can be
found in the LICENSE file.
Move this script to the
client/html/scripts
directory

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
File client/base/scripts/css_code_generator.py (right):

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
client/base/scripts/css_code_generator.py:99: // This file was generated by
base/scripts/css_code_generator.py
update this directory as part of the move

http://codereview.chromium.org/8360025/diff/1/client/html/src/CSSStyleDeclara...
File client/html/src/CSSStyleDeclarationWrappingImplementation.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/CSSStyleDeclara...
client/html/src/CSSStyleDeclarationWrappingImplementation.dart:75:
getPropertyValue('${CSSStyleDeclarationWrappingImplementation._browserPrefix}animation');
can't this just be 
_browserPrefix instead of 
CSSStyleDeclarationWrappingImplementation._browserPrefix?

http://codereview.chromium.org/8360025/diff/1/client/html/src/Device.dart
File client/html/src/Device.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/Device.dart#new...
client/html/src/Device.dart:8: * TODO(nweiz): rename this when we get rid of
client/base/Device.dart.
Remove this TODO as we want this class to be private for now as we don't want
users depending on it.

http://codereview.chromium.org/8360025/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:109: class
EmptyStyleDeclaration extends CSSStyleDeclarationWrappingImplementation {
this doesn't seem right... what will _ptr be set to?

[nweiz, 2011-10-24 19:48:28]

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
File client/base/scripts/css_code_generator.py (left):

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
client/base/scripts/css_code_generator.py:5: # BSD-style license that can be
found in the LICENSE file.
On 2011/10/21 17:12:23, jacobr wrote:
> Move this script to the
> client/html/scripts
> directory

Done.

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
File client/base/scripts/css_code_generator.py (right):

http://codereview.chromium.org/8360025/diff/1/client/base/scripts/css_code_ge...
client/base/scripts/css_code_generator.py:99: // This file was generated by
base/scripts/css_code_generator.py
On 2011/10/21 17:12:23, jacobr wrote:
> update this directory as part of the move

Done.

http://codereview.chromium.org/8360025/diff/1/client/html/src/CSSStyleDeclara...
File client/html/src/CSSStyleDeclarationWrappingImplementation.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/CSSStyleDeclara...
client/html/src/CSSStyleDeclarationWrappingImplementation.dart:75:
getPropertyValue('${CSSStyleDeclarationWrappingImplementation._browserPrefix}animation');
On 2011/10/21 17:12:23, jacobr wrote:
> can't this just be 
> _browserPrefix instead of 
> CSSStyleDeclarationWrappingImplementation._browserPrefix?

Oh, I suppose it can.

http://codereview.chromium.org/8360025/diff/1/client/html/src/Device.dart
File client/html/src/Device.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/Device.dart#new...
client/html/src/Device.dart:8: * TODO(nweiz): rename this when we get rid of
client/base/Device.dart.
On 2011/10/21 17:12:23, jacobr wrote:
> Remove this TODO as we want this class to be private for now as we don't want
> users depending on it.

Done.

http://codereview.chromium.org/8360025/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:109: class
EmptyStyleDeclaration extends CSSStyleDeclarationWrappingImplementation {
On 2011/10/21 17:12:23, jacobr wrote:
> this doesn't seem right... what will _ptr be set to?

It shouldn't need to be set to anything. We override all the methods that use
_ptr to return default values. The reason we're extending is so we don't have to
generate all the get/set methods, which ultimately call {get,set}PropertyValue
anyway.

[Jacob, 2011-10-24 20:07:15]

lgtm

http://codereview.chromium.org/8360025/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8360025/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:109: class
EmptyStyleDeclaration extends CSSStyleDeclarationWrappingImplementation {
On 2011/10/24 19:48:28, nweiz wrote:
> On 2011/10/21 17:12:23, jacobr wrote:
> > this doesn't seem right... what will _ptr be set to?
> 
> It shouldn't need to be set to anything. We override all the methods that use
> _ptr to return default values. The reason we're extending is so we don't have
to
> generate all the get/set methods, which ultimately call {get,set}PropertyValue
> anyway.
clever