Issue 8359002: Fix libraryDepsVisitor to properly track prefixed library references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8359002: Fix libraryDepsVisitor to properly track prefixed library references (Closed)

Created:
9 years, 2 months ago by jbrosenberg

Modified:
9 years, 2 months ago

Reviewers:
codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fix libraryDepsVisitor to properly track prefixed library references Committed: https://code.google.com/p/dart/source/detail?r=585

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+224 lines, -1 line)			Patch
M	compiler/java/com/google/dart/compiler/LibraryDepsVisitor.java	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/End2EndTests.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java	View	1 chunk	+159 lines, -0 lines	0 comments	Download
A	compiler/javatests/com/google/dart/compiler/end2end/inc/my.prefixed.app.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	compiler/javatests/com/google/dart/compiler/end2end/inc/my.unprefixed.app.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	compiler/javatests/com/google/dart/compiler/end2end/inc/some.prefixable.lib.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	compiler/javatests/com/google/dart/compiler/end2end/inc/some.prefixable.modified.lib.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jbrosenberg

This fixes the dependency visitor for prefixed library references (and includes a test that is ...

9 years, 2 months ago (2011-10-20 16:16:59 UTC) #1

codefu

9 years, 2 months ago (2011-10-20 16:52:51 UTC) #2

On 2011/10/20 16:16:59, jbrosenberg wrote:
> This fixes the dependency visitor for prefixed library references (and
includes
> a test that is fixed by this change).
> 
> It passes all the tests, etc.
> 
> Since this visitor is a model for the work we've been doing with treeshaking,
> etc., I think it's important to fix this (even if we don't ultimately remain
> committed to incremental compilation).

LGTM

Expand Messages | Collapse Messages