Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 8357002: Disabled failing tests. (Closed)

Created:
9 years, 2 months ago by jrgfogh
Modified:
9 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Disabled failing tests. Committed: https://code.google.com/p/dart/source/detail?r=552

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tests/standalone/src/TimerCancel1Test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 2 chunks +3 lines, -2 lines 4 comments Download

Messages

Total messages: 3 (0 generated)
jrgfogh
9 years, 2 months ago (2011-10-19 14:20:52 UTC) #1
Søren Gjesse
lgtm http://codereview.chromium.org/8357002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): http://codereview.chromium.org/8357002/diff/1/tests/standalone/standalone.status#newcode9 tests/standalone/standalone.status:9: TimerCancel1Test: Skip Please open a bug and document ...
9 years, 2 months ago (2011-10-19 14:22:44 UTC) #2
jrgfogh
9 years, 2 months ago (2011-10-19 14:26:41 UTC) #3
http://codereview.chromium.org/8357002/diff/1/tests/standalone/standalone.status
File tests/standalone/standalone.status (right):

http://codereview.chromium.org/8357002/diff/1/tests/standalone/standalone.sta...
tests/standalone/standalone.status:9: TimerCancel1Test: Skip
On 2011/10/19 14:22:44, Søren Gjesse wrote:
> Please open a bug and document it here.

Done.

http://codereview.chromium.org/8357002/diff/1/tests/standalone/standalone.sta...
tests/standalone/standalone.status:40: TimerCancelTest: Skip # Uses EventHandler
On 2011/10/19 14:22:44, Søren Gjesse wrote:
> Dies the TimerCancelTest tese still exist?

Yes.

Powered by Google App Engine
This is Rietveld 408576698