Issue 8355041: Some performance improvements to make raytracer faster (e.g, support intensified operation in mix...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8355041: Some performance improvements to make raytracer faster (e.g, support intensified operation in mix... (Closed)

Created:
9 years, 2 months ago by srdjan

Modified:
9 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Some performance improvements to make raytracer faster (e.g, support intensified operation in mixed double/smi, constant folding). Committed: https://code.google.com/p/dart/source/detail?r=596

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -11 lines)			Patch
M	runtime/vm/intrinsifier_ia32.cc	View	7 chunks	+47 lines, -10 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+26 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with comment regarding divide by 0.0 http://codereview.chromium.org/8355041/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/8355041/diff/1/runtime/vm/parser.cc#newcode5055 runtime/vm/parser.cc:5055: dbl_obj = ...

9 years, 2 months ago (2011-10-21 00:41:52 UTC) #2

srdjan

9 years, 2 months ago (2011-10-21 06:52:59 UTC) #3

http://codereview.chromium.org/8355041/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8355041/diff/1/runtime/vm/parser.cc#newcode5055
runtime/vm/parser.cc:5055: dbl_obj = Double::New(left_double / right_double);
On 2011/10/21 00:41:52, asiva wrote:
> what if right_double is 0.0?
> Also do you have to do something special if left_double is Nan or right_double
> is Nan.

The division in C++ behaves the same as in Dart (see Double_div in double.cc).
For definition of division by 0.0 see also interface double (Infinity or NaN).

Expand Messages | Collapse Messages