Make DocumentFragment implement Element.

Make DocumentFragment implement Element.

Committed: https://code.google.com/p/dart/source/detail?r=587

[Jacob, 2011-10-19 23:36:03]

Great tests!

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragment.dart (left):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragment.dart:9: Element query(String selectors);
remove these two methods. They're already defined on Element.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragment.dart (right):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragment.dart:5: interface DocumentFragment extends
Node, Element factory DocumentFragmentWrappingImplementation {
Element extends Node so no need to mark this as extending both.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (left):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:8: factory
DocumentFragmentWrappingImplementation() {
nit: move this factory before the .html factory in the list of factories as it
has 0 args.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:25: }
return null explicitly

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:36: if (newLength >=
length) {
length is somewhat costly to compute so cache it at the start of this fn.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:145: ElementEvents
_on;
there's already an _on property declared by the NodeWrappingImplementation class
this extends.

[nweiz, 2011-10-19 23:42:09]

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragment.dart (left):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragment.dart:9: Element query(String selectors);
On 2011/10/19 23:36:03, jacobr wrote:
> remove these two methods. They're already defined on Element.

Done.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragment.dart (right):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragment.dart:5: interface DocumentFragment extends
Node, Element factory DocumentFragmentWrappingImplementation {
On 2011/10/19 23:36:03, jacobr wrote:
> Element extends Node so no need to mark this as extending both.

Done.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (left):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:8: factory
DocumentFragmentWrappingImplementation() {
On 2011/10/19 23:36:03, jacobr wrote:
> nit: move this factory before the .html factory in the list of factories as it
> has 0 args.

Done.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
File client/html/src/DocumentFragmentWrappingImplementation.dart (right):

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:25: }
On 2011/10/19 23:36:03, jacobr wrote:
> return null explicitly

Done.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:36: if (newLength >=
length) {
On 2011/10/19 23:36:03, jacobr wrote:
> length is somewhat costly to compute so cache it at the start of this fn.

Done.

http://codereview.chromium.org/8355019/diff/1/client/html/src/DocumentFragmen...
client/html/src/DocumentFragmentWrappingImplementation.dart:145: ElementEvents
_on;
On 2011/10/19 23:36:03, jacobr wrote:
> there's already an _on property declared by the NodeWrappingImplementation
class
> this extends.

Done.

[Jacob, 2011-10-19 23:43:54]

One more thing, Remove the ClientRectList class from the generated directory and
from html.dart

[Jacob, 2011-10-19 23:46:01]

lgtm

[nweiz, 2011-10-20 00:07:54]

On 2011/10/19 23:43:54, jacobr wrote:
> One more thing, Remove the ClientRectList class from the generated directory
and
> from html.dart

I don't think I can actually get rid of ClientRectList, since I'm still
accessing it in ElementWrappingImplementation in order to build the
List<ClientRect>.