- Make sure to test all combinations of getters.

- Make sure to test all combinations of getters.
Committed: https://code.google.com/p/dart/source/detail?r=573

[Ivan Posva, 2011-10-19 20:29:23]

Including Gilad to make sure that the test does follow what the specification
states.

-Ivan

[ngeoffray, 2011-10-19 20:40:38]

Nice, thanks Ivan!

LGTM!

[hausner, 2011-10-19 20:48:34]

Nice! 

LGTM.

[gbracha, 2011-10-19 20:55:19]

The original test was broken, because the rules for top function invocations are
different. This breakage is still in the current test!

The new sections are ok, but we should consider if we really want this behavior
for static getters. Perhaps they should behave the same as top level functions.

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
File language/src/GetterClosureExecutionOrderTest.dart (left):

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
language/src/GetterClosureExecutionOrderTest.dart:11: Expect.equals(1, counter);
This should be 0. This is a top level getter, and when invoked it will be
evaluated before its arguments. In other words, this part of the test is
invalid.

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
File language/src/GetterClosureExecutionOrderTest.dart (right):

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
language/src/GetterClosureExecutionOrderTest.dart:32: Expect.equals(0, counter);
This should expect counter = 1. See comment below.

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
language/src/GetterClosureExecutionOrderTest.dart:63: // Check static getters.
This is valid per the current spec, though perhaps that should change to agree
with the top level case.

[Ivan Posva, 2011-10-19 21:26:16]

Thanks! Updated the test, submitting.

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
File language/src/GetterClosureExecutionOrderTest.dart (left):

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
language/src/GetterClosureExecutionOrderTest.dart:11: Expect.equals(1, counter);
On 2011/10/19 20:55:19, gbracha wrote:
> This should be 0. This is a top level getter, and when invoked it will be
> evaluated before its arguments. In other words, this part of the test is
> invalid.

Done.

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
File language/src/GetterClosureExecutionOrderTest.dart (right):

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
language/src/GetterClosureExecutionOrderTest.dart:32: Expect.equals(0, counter);
On 2011/10/19 20:55:19, gbracha wrote:
> This should expect counter = 1. See comment below.

Done.

http://codereview.chromium.org/8355014/diff/1/language/src/GetterClosureExecu...
language/src/GetterClosureExecutionOrderTest.dart:63: // Check static getters.
On 2011/10/19 20:55:19, gbracha wrote:
> This is valid per the current spec, though perhaps that should change to agree
> with the top level case.

Done.