Allow callbackDone while test is executed by runTest.

Allow callbackDone while test is executed by runTest.
Committed: https://code.google.com/p/dart/source/detail?r=567

[Siggi Cherem (dart-lang), 2011-10-19 16:57:41]

Could you share here a use-case/sample for why we need this?

http://codereview.chromium.org/8354006/diff/1/client/testing/unittest/unittes...
File client/testing/unittest/unittestsuite.dart (right):

http://codereview.chromium.org/8354006/diff/1/client/testing/unittest/unittes...
client/testing/unittest/unittestsuite.dart:45: * Whether test is currently being
executed by [:runTest:].
(3 minor nits):
- "Whether test..." => "Whether a test..."
- since this comment is short enough, let's use a single line:
/** Whether ... */
- since this is a reference to a method, not actual quoted code, use [runTest]
rather than [:runTest:]

[Siggi Cherem (dart-lang), 2011-10-19 18:42:40]

lgtm (addressing comment below)

Thanks for the example/clarification.

http://codereview.chromium.org/8354006/diff/3001/client/testing/unittest/unit...
File client/testing/unittest/unittestsuite.dart (right):

http://codereview.chromium.org/8354006/diff/3001/client/testing/unittest/unit...
client/testing/unittest/unittestsuite.dart:164: testCase.recordSuccess();
shouldn't this be inside the conditional too?

[Anton Muhin, 2011-10-19 18:51:58]

http://codereview.chromium.org/8354006/diff/3001/client/testing/unittest/unit...
File client/testing/unittest/unittestsuite.dart (right):

http://codereview.chromium.org/8354006/diff/3001/client/testing/unittest/unit...
client/testing/unittest/unittestsuite.dart:164: testCase.recordSuccess();
On 2011/10/19 18:42:41, sigmund wrote:
> shouldn't this be inside the conditional too?

I don't think so, but, please, double check: if test called callbackDone
expected number of times, the test has successfully finished which should be
recorded, but we just shouldn't start next test.  Does that sound reasonable?

[Siggi Cherem (dart-lang), 2011-10-19 19:56:21]

http://codereview.chromium.org/8354006/diff/3001/client/testing/unittest/unit...
File client/testing/unittest/unittestsuite.dart (right):

http://codereview.chromium.org/8354006/diff/3001/client/testing/unittest/unit...
client/testing/unittest/unittestsuite.dart:164: testCase.recordSuccess();
On 2011/10/19 18:51:58, antonmuhin wrote:
> On 2011/10/19 18:42:41, sigmund wrote:
> > shouldn't this be inside the conditional too?
> 
> I don't think so, but, please, double check: if test called callbackDone
> expected number of times, the test has successfully finished which should be
> recorded, but we just shouldn't start next test.  Does that sound reasonable?

I think that might be covered in [runTests] also (in line 201).