Issue 8351031: Temporary suppress the tests. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(809)

My Issues | Starred Open | Closed | All

Issue 8351031: Temporary suppress the tests. (Closed)

Created:
9 years, 1 month ago by Anton Muhin

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang), ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Temporary suppress the tests. Committed: https://code.google.com/p/dart/source/detail?r=681

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	client/tests/client/client.status	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

TBRing Siggi, most probably due to new unit test framework: === debugdartium client/html/html_tests === Path: ...

9 years, 1 month ago (2011-10-25 10:14:38 UTC) #1

TBRing

Siggi, most probably due to new unit test framework:


=== debugdartium client/html/html_tests ===
Path: client/html/html_tests
--- stdout ---
CONSOLE MESSAGE: line 0: Exception: Cannot have two UnitTestSuites in flight at
the same time.
Stack Trace:  0. Function: 'UnitTestSuite.UnitTestSuite.' url: 'html_tests.dart'
line:21 col:29

Content-Type: text/plain
FAIL
1	PASS
2	PASS
3	ERROR	Caught NotImplementedException
 0. Function: 'CSSStyleDeclarationImplementation.getPropertyCSSValue' url:
'CSSStyleDeclaration' line:72 col:3
 1. Function: 'CSSStyleDeclarationWrappingImplementation.getPropertyCSSValue'
url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/src/CSSStyleDeclarationWrappingImplementation.dart'
line:39 col:58
 2. Function: 'CSSStyleDeclarationTests.testGetPropertyCSSValue' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/tests/client/html/CSSStyleDeclarationTests.dart'
line:36 col:53
 3. Function: 'UnitTestSuite.runTest' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/testing/unittest/unittestsuite.dart'
line:196 col:22
4	PASS
5	PASS
6	PASS
7	ERROR	Caught Failed type check: type WindowWrappingImplementation is not
assignable to type Window of function result in
file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/generated/src/wrapping/_HtmlWrappingImplementation.dart
at line 1926, column 12.
 0. Function: 'LevelDom.wrapWindow' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/generated/src/wrapping/_HtmlWrappingImplementation.dart'
line:1926 col:12
 1. Function: 'LevelDom.initialize' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/generated/src/wrapping/_HtmlWrappingImplementation.dart'
line:1959 col:30
 2. Function: 'get:window' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/src/GlobalProperties.dart'
line:10 col:24
 3. Function: '_Device@38cc8790.get:userAgent' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/src/Device.dart'
line:14 col:36
 4. Function: '_Device@38cc8790.get:isFirefox' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/src/Device.dart'
line:19 col:34
 5. Function:
'CSSStyleDeclarationWrappingImplementation.get:_browserPrefix@38cc8790' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/src/CSSStyleDeclarationWrappingImplementation.dart'
line:20 col:28
 6. Function: 'CSSStyleDeclarationWrappingImplementation.get:transform' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/html/src/CSSStyleDeclarationWrappingImplementation.dart'
line:2586 col:25
 7. Function: 'CSSStyleDeclarationTests.testGettersAndSetters' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/tests/client/html/CSSStyleDeclarationTests.dart'
line:64 col:51
 8. Function: 'UnitTestSuite.runTest' url:
'file:///mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/testing/unittest/unittestsuite.dart'
line:196 col:22
Total 5 passed, 0 failed 2 errors
#EOF
Command:
/mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/tests/drt/DumpRenderTree
--no-timeout "--dart-flags=--enable_asserts --enable_type_checks
--ignore-unrecognized-flags"
/mnt/data/b/build/slave/dart_client-linux-dartium-debug/build/dart/client/out/Debug_dartium/client_tests_client_html_html_tests.dart.dartium.html

I'll try to fix if I have some cycles.  Please, redispatch otherwise.

ngeoffray

LGTM http://codereview.chromium.org/8351031/diff/1/client/tests/client/client.status File client/tests/client/client.status (right): http://codereview.chromium.org/8351031/diff/1/client/tests/client/client.status#newcode10 client/tests/client/client.status:10: html/html_tests: Skip # Due to unit test framework ...

9 years, 1 month ago (2011-10-25 10:16:32 UTC) #2

Anton Muhin

9 years, 1 month ago (2011-10-25 10:39:48 UTC) #3

http://codereview.chromium.org/8351031/diff/1/client/tests/client/client.status
File client/tests/client/client.status (right):

http://codereview.chromium.org/8351031/diff/1/client/tests/client/client.stat...
client/tests/client/client.status:10: html/html_tests: Skip # Due to unit test
framework update.
On 2011/10/25 10:16:32, ngeoffray wrote:
> Why not Fail?

Good point, thanks a lot: http://codereview.chromium.org/8383035

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698