Issue 8351013: Correct method override checks to conform to the spec.wq

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8351013: Correct method override checks to conform to the spec.wq (Closed)

Created:
9 years, 2 months ago by John Lenz

Modified:
9 years, 2 months ago

Reviewers:
jat

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Tweaks to overriden method checks to match the spec. Committed: https://code.google.com/p/dart/source/detail?r=668

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -20 lines)			Patch
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	6 chunks	+17 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/Types.java	View	2 chunks	+22 lines, -10 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	5 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jat

LGTM Is there a language test negative test that checks this? If not, there should ...

9 years, 2 months ago (2011-10-24 22:00:21 UTC) #2

John Lenz

9 years, 2 months ago (2011-10-24 23:18:27 UTC) #3

On 2011/10/24 22:00:21, jat wrote:
> LGTM
> 
> Is there a language test negative test that checks this?  If not, there should
> be one.

There should be one, but I won't be adding one.

Expand Messages | Collapse Messages