Issue 8347008: Address review comments of previously submitted cl 8329005.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8347008: Address review comments of previously submitted cl 8329005. (Closed)

Created:
9 years, 2 months ago by regis

Modified:
9 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Address review comments of previously submitted cl 8329005. Committed: https://code.google.com/p/dart/source/detail?r=531

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -31 lines)			Patch
M	runtime/vm/code_generator.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	8 chunks	+14 lines, -15 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm