Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 8346030: Fixed NullPointerException in Timer. (Closed)

Created:
9 years, 2 months ago by jrgfogh
Modified:
9 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fixed NullPointerException in Timer. Committed: https://code.google.com/p/dart/source/detail?r=547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M runtime/bin/timer_impl.dart View 2 chunks +11 lines, -10 lines 0 comments Download
A runtime/tests/dart/src/TimerCancel1Test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A runtime/tests/dart/src/TimerCancel2Test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jrgfogh
9 years, 2 months ago (2011-10-19 09:26:53 UTC) #1
Søren Gjesse
lgtm You want to keep TimerCancelTest.dart?
9 years, 2 months ago (2011-10-19 09:28:47 UTC) #2
jrgfogh
9 years, 2 months ago (2011-10-19 09:34:50 UTC) #3
On 2011/10/19 09:28:47, Søren Gjesse wrote:
> lgtm
> 
> You want to keep TimerCancelTest.dart?

Git renamed it back to TimerCancelTest.dart from TimerCancelTest0.dart when I
rebased my repo. I figured it didn't matter.

Powered by Google App Engine
This is Rietveld 408576698