Issue 8346018: Insure that isolate specific methods are generated after "inherits"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8346018: Insure that isolate specific methods are generated after "inherits" (Closed)

Created:
9 years, 2 months ago by John Lenz

Modified:
9 years, 2 months ago

Reviewers:
pdr

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Insure that isolate specific methods are generated after "inherits". Fixes isolates in Internet Explorer. Committed: https://code.google.com/p/dart/source/detail?r=542

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

pdr

9 years, 2 months ago (2011-10-18 23:27:13 UTC) #2

On 2011/10/18 23:19:05, John Lenz wrote:

LGTM

Verified it works on a simple test case and on Dartboard's isolate sample.