Clean up swarm tests to new API.

Clean up swarm tests to new API.

Committed: https://code.google.com/p/dart/source/detail?r=541

[Siggi Cherem (dart-lang), 2011-10-18 22:26:50]

lgtm

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
File client/tests/client/samples/swarm/swarm_tests.dart (left):

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
client/tests/client/samples/swarm/swarm_tests.dart:15: new SwarmTests().run();
it's so nice to get rid of this...

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
File client/tests/client/samples/swarm/swarm_tests.dart (right):

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
client/tests/client/samples/swarm/swarm_tests.dart:103: click(Element element) {
any reason to make this public (_click seemed ok)?

[Jennifer Messerly, 2011-10-18 22:46:01]

lgtm

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
File client/tests/client/samples/swarm/swarm_tests.dart (right):

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
client/tests/client/samples/swarm/swarm_tests.dart:103: click(Element element) {
On 2011/10/18 22:26:50, sigmund wrote:
> any reason to make this public (_click seemed ok)?

Agree.

But even better would be to have this in the DOM somewhere, as the TODO below
notes :)

[Bob Nystrom, 2011-10-18 23:10:50]

Thanks!

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
File client/tests/client/samples/swarm/swarm_tests.dart (left):

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
client/tests/client/samples/swarm/swarm_tests.dart:15: new SwarmTests().run();
On 2011/10/18 22:26:50, sigmund wrote:
> it's so nice to get rid of this... 

Yes!

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
File client/tests/client/samples/swarm/swarm_tests.dart (right):

http://codereview.chromium.org/8345023/diff/1/client/tests/client/samples/swa...
client/tests/client/samples/swarm/swarm_tests.dart:103: click(Element element) {
On 2011/10/18 22:26:50, sigmund wrote:
> any reason to make this public (_click seemed ok)?

I made it public just because most of the other tests (and our libraries in
general) seem to not worry too much about making things private. I think private
matters a lot for a library intended to be re-used and consumed by other
programs, but maybe not so much for top-level programs or things like tests.