Issue 8344084: Do not mark test as successful in callbackDone if test is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8344084: Do not mark test as successful in callbackDone if test is (Closed)

Created:
9 years, 2 months ago by Anton Muhin

Modified:
9 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Do not mark test as successful in callbackDone if test is still running. Committed: https://code.google.com/p/dart/source/detail?r=584

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	client/testing/unittest/unittestsuite.dart	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm Thanks Anton! http://codereview.chromium.org/8344084/diff/1/client/testing/unittest/unittestsuite.dart File client/testing/unittest/unittestsuite.dart (right): http://codereview.chromium.org/8344084/diff/1/client/testing/unittest/unittestsuite.dart#newcode164 client/testing/unittest/unittestsuite.dart:164: if (!_testIsRunning) { (nit) maybe this ...

9 years, 2 months ago (2011-10-20 15:00:13 UTC) #2

Anton Muhin

9 years, 2 months ago (2011-10-20 16:59:06 UTC) #3

http://codereview.chromium.org/8344084/diff/1/client/testing/unittest/unittes...
File client/testing/unittest/unittestsuite.dart (right):

http://codereview.chromium.org/8344084/diff/1/client/testing/unittest/unittes...
client/testing/unittest/unittestsuite.dart:164: if (!_testIsRunning) {
On 2011/10/20 15:00:13, sigmund wrote:
> (nit) maybe this fits together with the previous condition?
> if (_callbacksCalled == testCase.callbacks && !_testIsRunning) {

Thanks, nice, done.

Expand Messages | Collapse Messages

Issue 8344084: Do not mark test as successful in callbackDone if test is (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages