Issue 8344019: Remove createXMLHttpRequest and other 'factory' constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8344019: Remove createXMLHttpRequest and other 'factory' constructors. (Closed)

Created:
9 years, 2 months ago by sra1

Modified:
9 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Remove createXMLHttpRequest and other 'factory' constructors. These are now available with 'new' syntax (i.e. from genuine factory constructors.) BUG=5464478 TEST= Committed: https://code.google.com/p/dart/source/detail?r=537

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -135 lines)			Patch
M	client/dom/generated/monkey_dom.js	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	client/dom/generated/monkey_dom_externs.js	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	client/dom/generated/src/interface/DOMWindow.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	client/dom/generated/wrapping_dom.js	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	client/dom/generated/wrapping_dom_externs.js	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	client/dom/idl/dart/dart.idl	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	client/dom/scripts/template_wrapping_dom.js	View	1 chunk	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages