When generating snapshots for a specified script don't include the builtin library by default. Th...

When generating snapshots for a specified script don't include the builtin library by default. The DOM snap shot for instance does not want the builtin library. If the builtin library is needed it needs to be explicitly imported in the specified script.
Committed: https://code.google.com/p/dart/source/detail?r=971

[Anton Muhin, 2011-10-31 08:34:22]

LGTM, but shouldn't you compensate for omitting this import somehow?

[siva, 2011-10-31 17:08:57]

- made setting of built-in resolver conditional to the default stand alone case.
- the snapshot should not have root-library set as it is just a snapshot and a
script is going to be loaded on top of that.

[siva, 2011-10-31 17:41:35]

PTAL.

Fixes the case of builtin lib being added in the snapshot script loading event
hough we don't want that.

[Anton Muhin, 2011-10-31 17:48:34]

LGTM

Maybe rename --scripts argument to something like --libs?

I am going to patch this change in asap and give it another try.

http://codereview.chromium.org/8343071/diff/7004/bin/process_script.cc
File bin/process_script.cc (right):

http://codereview.chromium.org/8343071/diff/7004/bin/process_script.cc#newcode89
bin/process_script.cc:89: enum ImportBuiltin {
nit: I would rather have two bool constants for it, but that's pretty personal.

http://codereview.chromium.org/8343071/diff/7004/bin/process_script.cc#newcod...
bin/process_script.cc:145: // TODO(iposva): Should the builtin library be added
to all libraries?
may TODO go away or get moved into MainLibraryTagHandler?

[siva, 2011-10-31 21:09:32]

http://codereview.chromium.org/8343071/diff/7004/bin/process_script.cc
File bin/process_script.cc (right):

http://codereview.chromium.org/8343071/diff/7004/bin/process_script.cc#newcode89
bin/process_script.cc:89: enum ImportBuiltin {
On 2011/10/31 17:48:34, antonmuhin wrote:
> nit: I would rather have two bool constants for it, but that's pretty
personal.

Done.

http://codereview.chromium.org/8343071/diff/7004/bin/process_script.cc#newcod...
bin/process_script.cc:145: // TODO(iposva): Should the builtin library be added
to all libraries?
On 2011/10/31 17:48:34, antonmuhin wrote:
> may TODO go away or get moved into MainLibraryTagHandler?

Done.