Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 8341119: Get rid of use of dart:html in unittestlib. (Closed)

Created:
9 years, 1 month ago by Bob Nystrom
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of use of dart:html in unittestlib. Committed: https://code.google.com/p/dart/source/detail?r=920

Patch Set 1 #

Patch Set 2 : Remove old comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -43 lines) Patch
M client/testing/unittest/unittest.dart View 1 1 chunk +4 lines, -8 lines 0 comments Download
D client/testing/unittest/unittest_dom.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M client/testing/unittest/unittestsuite.dart View 4 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Instead of supporting both dart:html and dart:dom, this makes unittest just always use dart:dom. It ...
9 years, 1 month ago (2011-10-28 20:56:20 UTC) #1
Siggi Cherem (dart-lang)
lgtm
9 years, 1 month ago (2011-10-28 21:24:25 UTC) #2
Jacob
9 years, 1 month ago (2011-10-28 21:39:58 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698