Issue 8341118: Add two constructor tests

Issue 8341118: Add two constructor tests (Closed)

Created:
9 years, 1 month ago by hausner

Modified:
9 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Add two constructor tests Check evaluation order of initializers. Committed: https://code.google.com/p/dart/source/detail?r=919

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -1 line)			Patch
M	tests/language/language.status	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
A	tests/language/src/Constructor2Test.dart	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
A	tests/language/src/Constructor3Test.dart	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/8341118/diff/2001/tests/language/src/Constructor2Test.dart File tests/language/src/Constructor2Test.dart (right): http://codereview.chromium.org/8341118/diff/2001/tests/language/src/Constructor2Test.dart#newcode39 tests/language/src/Constructor2Test.dart:39: print(trace); Do you want to leave this print ...

9 years, 1 month ago (2011-10-28 20:29:32 UTC) #3

hausner

9 years, 1 month ago (2011-10-28 21:27:30 UTC) #4

Thanks

http://codereview.chromium.org/8341118/diff/2001/tests/language/src/Construct...
File tests/language/src/Constructor2Test.dart (right):

http://codereview.chromium.org/8341118/diff/2001/tests/language/src/Construct...
tests/language/src/Constructor2Test.dart:39: print(trace);
On 2011/10/28 20:29:32, asiva wrote:
> Do you want to leave this print in the test? The verification in the next line
> should be good enough right.
> 
> If you leave it in, the test might fail on Dartium as they don't have print
> implemented.

Thanks for the warning. Removed.

http://codereview.chromium.org/8341118/diff/2001/tests/language/src/Construct...
File tests/language/src/Constructor3Test.dart (right):

http://codereview.chromium.org/8341118/diff/2001/tests/language/src/Construct...
tests/language/src/Constructor3Test.dart:37: print(trace);
On 2011/10/28 20:29:32, asiva wrote:
> Ditto comment about print

Done.

Expand Messages | Collapse Messages