Issue 8341112: Cleanup buildbot_annotated_steps.py to run and test at the top level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341112: Cleanup buildbot_annotated_steps.py to run and test at the top level. (Closed)

Created:
9 years, 1 month ago by ngeoffray

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Cleanup buildbot_annotated_steps.py to run and test at the top level. Committed: https://code.google.com/p/dart/source/detail?r=1091

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -41 lines)			Patch
	M	client/tools/buildbot_annotated_steps.py	View	1	7 chunks	+28 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm sorry it took me this long to reply - I saw the email on ...

9 years, 1 month ago (2011-11-01 23:09:43 UTC) #2

ngeoffray

9 years, 1 month ago (2011-11-02 13:51:34 UTC) #3

Thanks Siggi, and no problem for the delay.

http://codereview.chromium.org/8341112/diff/2001/client/tools/buildbot_annota...
File client/tools/buildbot_annotated_steps.py (right):

http://codereview.chromium.org/8341112/diff/2001/client/tools/buildbot_annota...
client/tools/buildbot_annotated_steps.py:133: version_file = os.path.join('.',
DARTIUM_VERSION_FILE)
On 2011/11/01 23:09:43, sigmund wrote:
> is this needed anymore? i.e can we simply inline DARTIUM_VERSION_FILE below?

Done.

http://codereview.chromium.org/8341112/diff/2001/client/tools/buildbot_annota...
client/tools/buildbot_annotated_steps.py:175: os.path.join('.', 'frog',
On 2011/11/01 23:09:43, sigmund wrote:
> remove first arg? possibly merge this line and the next?

Done.

Expand Messages | Collapse Messages