Issue 8341066: Fixes problem with running test.py --arch dartc --mode release,debug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341066: Fixes problem with running test.py --arch dartc --mode release,debug (Closed)

Created:
9 years, 1 month ago by zundel

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fixes problem with running test.py --arch dartc --mode release,debug The --optimize flag was set for all tests at the top level if release mode was specified. I pushed this logic down into the be a part of generating run command for each individual test case. BUG=5408215 Committed: https://code.google.com/p/dart/source/detail?r=768

Patch Set 1 #

Patch Set 2 : style change #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
M	tests/co19/testcfg.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/test.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/testing/architecture.py	View	1	4 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages