Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8341056: Add support for test expectations based on the --checked flag. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add support for test expectations based on the --checked flag. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=751

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tests/standalone/standalone.status View 2 chunks +6 lines, -10 lines 2 comments Download
M tools/test.py View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-10-26 14:12:03 UTC) #1
Søren Gjesse
lgtm
9 years, 1 month ago (2011-10-26 14:17:11 UTC) #2
Bill Hesse
http://codereview.chromium.org/8341056/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): http://codereview.chromium.org/8341056/diff/1/tests/standalone/standalone.status#newcode7 tests/standalone/standalone.status:7: [ $arch == ia32 && $checked ] Can you ...
9 years, 1 month ago (2011-10-26 14:18:17 UTC) #3
Mads Ager (google)
http://codereview.chromium.org/8341056/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): http://codereview.chromium.org/8341056/diff/1/tests/standalone/standalone.status#newcode7 tests/standalone/standalone.status:7: [ $arch == ia32 && $checked ] On 2011/10/26 ...
9 years, 1 month ago (2011-10-26 14:23:37 UTC) #4
Bill Hesse
9 years, 1 month ago (2011-10-26 14:27:40 UTC) #5
OK, I will adapt and thrive to the new crazy boolean and string variable world.

Powered by Google App Engine
This is Rietveld 408576698