Issue 8341032: Fix windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341032: Fix windows build. (Closed)

Created:
9 years, 1 month ago by siva

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Description

Fix windows build. TBR=regis. Committed: https://code.google.com/p/dart/source/detail?r=715

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bin/file_win.cc	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one question. http://codereview.chromium.org/8341032/diff/1/bin/file_win.cc File bin/file_win.cc (right): http://codereview.chromium.org/8341032/diff/1/bin/file_win.cc#newcode124 bin/file_win.cc:124: // TODO(176): Need to implement ...

9 years, 1 month ago (2011-10-25 21:18:14 UTC) #2

siva

9 years, 1 month ago (2011-10-25 21:55:26 UTC) #3

http://codereview.chromium.org/8341032/diff/1/bin/file_win.cc
File bin/file_win.cc (right):

http://codereview.chromium.org/8341032/diff/1/bin/file_win.cc#newcode124
bin/file_win.cc:124: // TODO(176): Need to implement this.
Oh it is 172, I will correct this.

On 2011/10/25 21:18:14, regis wrote:
> Is 176 the correct issue number?

Expand Messages | Collapse Messages