Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 8341003: Get touch tests working at all, and with new API. (Closed)

Created:
9 years, 2 months ago by Bob Nystrom
Modified:
9 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get touch tests working at all, and with new API. Committed: https://code.google.com/p/dart/source/detail?r=529

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark test as skipped instead of commenting out. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -54 lines) Patch
M client/testing/unittest/unittestsuite.dart View 1 chunk +11 lines, -5 lines 0 comments Download
M client/tests/client/client.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
D client/tests/client/touch/TouchTests.dart View 1 chunk +0 lines, -49 lines 0 comments Download
A client/tests/client/touch/touch_tests.dart View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
9 years, 2 months ago (2011-10-18 00:35:27 UTC) #1
Siggi Cherem (dart-lang)
http://codereview.chromium.org/8341003/diff/1/client/tests/client/touch/touch_tests.dart File client/tests/client/touch/touch_tests.dart (right): http://codereview.chromium.org/8341003/diff/1/client/tests/client/touch/touch_tests.dart#newcode17 client/tests/client/touch/touch_tests.dart:17: // them out for now until someone can take ...
9 years, 2 months ago (2011-10-18 00:39:20 UTC) #2
Bob Nystrom
http://codereview.chromium.org/8341003/diff/1/client/tests/client/touch/touch_tests.dart File client/tests/client/touch/touch_tests.dart (right): http://codereview.chromium.org/8341003/diff/1/client/tests/client/touch/touch_tests.dart#newcode17 client/tests/client/touch/touch_tests.dart:17: // them out for now until someone can take ...
9 years, 2 months ago (2011-10-18 01:01:10 UTC) #3
Siggi Cherem (dart-lang)
thanks! lgtm
9 years, 2 months ago (2011-10-18 01:31:42 UTC) #4
Jacob
9 years, 2 months ago (2011-10-18 01:33:57 UTC) #5
LGTM
didn't realize I'd accidentally checked these in.

Powered by Google App Engine
This is Rietveld 408576698