Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 8337009: Reapply "Support for precise stepping in functions compiled before debugging was started (step 2)" (Closed)

Created:
9 years, 2 months ago by Søren Gjesse
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reapply "Support for precise stepping in functions compiled before debugging was started (step 2)" This is reapplying r9501 with this single change which seemed to be causing most (all) of the failures for r9501. --- a/src/debug.cc +++ b/src/debug.cc @@ -2230,6 +2230,7 @@ Debugger::Debugger(Isolate* isolate) compiling_natives_(false), is_loading_debugger_(false), never_unload_debugger_(false), + force_debugger_active_(true), message_handler_(NULL), debugger_unload_pending_(false), host_dispatch_handler_(NULL), R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9684

Patch Set 1 #

Patch Set 2 : After rebase #

Patch Set 3 : Correct default value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -49 lines) Patch
M src/compiler.h View 4 chunks +22 lines, -3 lines 0 comments Download
M src/compiler.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M src/debug.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/debug.cc View 1 2 3 chunks +192 lines, -36 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/list-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M src/utils.h View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/debug-step-3.js View 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years, 2 months ago (2011-10-18 10:10:06 UTC) #1
Kevin Millikin (Chromium)
9 years, 2 months ago (2011-10-18 10:13:43 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698