Issue 8337004: Move layout tests to new API.

Issue 8337004: Move layout tests to new API. (Closed)

Created:
9 years, 2 months ago by Bob Nystrom

Modified:
9 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Move layout tests to new API. Committed: https://code.google.com/p/dart/source/detail?r=522

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+166 lines, -200 lines)			Patch
M	client/tests/client/layout/GridLayoutDemo.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download
D	client/tests/client/layout/GridLayoutTests.dart	View	1 chunk	+0 lines, -196 lines	0 comments	Download
M	client/tests/client/layout/layout_tests.dart	View	1 chunk	+164 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm http://codereview.chromium.org/8337004/diff/1/client/tests/client/layout/GridLayoutDemo.dart File client/tests/client/layout/GridLayoutDemo.dart (right): http://codereview.chromium.org/8337004/diff/1/client/tests/client/layout/GridLayoutDemo.dart#newcode107 client/tests/client/layout/GridLayoutDemo.dart:107: sb.add("test('Spec Example $exampleId', () {\n"); just to understand ...

9 years, 2 months ago (2011-10-18 01:29:56 UTC) #2

Bob Nystrom

On 2011/10/18 01:29:56, sigmund wrote: > lgtm > > http://codereview.chromium.org/8337004/diff/1/client/tests/client/layout/GridLayoutDemo.dart > File client/tests/client/layout/GridLayoutDemo.dart (right): > ...

9 years, 2 months ago (2011-10-18 17:14:10 UTC) #3

Bob Nystrom

9 years, 2 months ago (2011-10-18 17:14:19 UTC) #4

http://codereview.chromium.org/8337004/diff/1/client/tests/client/layout/Grid...
File client/tests/client/layout/GridLayoutDemo.dart (right):

http://codereview.chromium.org/8337004/diff/1/client/tests/client/layout/Grid...
client/tests/client/layout/GridLayoutDemo.dart:107: sb.add("test('Spec Example
$exampleId', () {\n");
On 2011/10/18 01:29:56, sigmund wrote:
> just to understand this code better - this is just for logging (maybe
copy/paste
> to generate individual tests?) it should have no effects, right?

Yeah, I believe so. I can check with John to make sure.

Expand Messages | Collapse Messages