Add status_file_parser.dart library, and tests for it, to the Dart rewrite of the test suite runner.

Add status_file_parser.dart library, and tests for it, to the Dart rewrite of the test suite runner.


BUG=
TEST=standalone/StatusFileParserTest

Committed: https://code.google.com/p/dart/source/detail?r=1076

[Mads Ager (google), 2011-10-31 16:05:19]

LGTM with comments.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
File tools/testing/dart/status_file.dart (right):

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:5: #library("status_file");
status_file_parser maybe?

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:30: String SplitPath(String path) => path;
Could you comment on this identity function. Is there a need for it? If there
is, could you add a TODO explaining what it is supposed to do?

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:41: 
Remove extra blank line?

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:43: while (true) {
We could do something like:

String line;
while ((line = lines.readLine()) != null) {
  ...
}

To avoid the while(true), break.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:63: String path = prefix +
SplitPath(match[1].trim());
Since SplitPath is the identify function, I would remove it until you know how
you will use this. SplitPath looks like something that will return a list on
which you cannot use +, so I don't think it makes sense to keep it as is.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:74: prefix = SplitPath(match[1]);
Add a TODO here as well?

[Bill Hesse, 2011-11-02 10:15:43]

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
File tools/testing/dart/status_file.dart (right):

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:5: #library("status_file");
On 2011/10/31 16:05:20, Mads Ager wrote:
> status_file_parser maybe?

Done.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:30: String SplitPath(String path) => path;
On 2011/10/31 16:05:20, Mads Ager wrote:
> Could you comment on this identity function. Is there a need for it? If there
> is, could you add a TODO explaining what it is supposed to do?

Done.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:41: 
On 2011/10/31 16:05:20, Mads Ager wrote:
> Remove extra blank line?

Done.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:43: while (true) {
On 2011/10/31 16:05:20, Mads Ager wrote:
> We could do something like:
> 
> String line;
> while ((line = lines.readLine()) != null) {
>   ...
> }
> 
> To avoid the while(true), break.

Done.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:63: String path = prefix +
SplitPath(match[1].trim());
On 2011/10/31 16:05:20, Mads Ager wrote:
> Since SplitPath is the identify function, I would remove it until you know how
> you will use this. SplitPath looks like something that will return a list on
> which you cannot use +, so I don't think it makes sense to keep it as is.

Done.

http://codereview.chromium.org/8335008/diff/1/tools/testing/dart/status_file....
tools/testing/dart/status_file.dart:74: prefix = SplitPath(match[1]);
On 2011/10/31 16:05:20, Mads Ager wrote:
> Add a TODO here as well?

Done.