Issue 8334031: - Fix the snapshot generation python script to return an error code when snapshot generation fail...

Issue 8334031: - Fix the snapshot generation python script to return an error code when snapshot generation fail... (Closed)

Created:
9 years, 1 month ago by siva

Modified:
9 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Description

- Fix the snapshot generation python script to return an error code when snapshot generation fails and print the error message. - Split isolate creation into CreateIsolate and InitializeIsolate so that we don't get SEGVs when there is a failure compiling the corelib dart sources during the bootstrap process Committed: https://code.google.com/p/dart/source/detail?r=1225

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -24 lines)			Patch
M	lib/isolate.cc	View	1	2 chunks	+16 lines, -6 lines	0 comments	Download
M	tools/create_snapshot_file.py	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	vm/dart.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/dart.cc	View	1	4 chunks	+16 lines, -7 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	1	1 chunk	+22 lines, -4 lines	0 comments	Download
M	vm/message_queue_test.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	vm/port_test.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	vm/unit_test.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan http://codereview.chromium.org/8334031/diff/1/lib/isolate.cc File lib/isolate.cc (right): http://codereview.chromium.org/8334031/diff/1/lib/isolate.cc#newcode273 lib/isolate.cc:273: spawned_isolate->set_long_jump_base(NULL); Why not resetting it ...

9 years, 1 month ago (2011-11-04 17:24:42 UTC) #2

siva

9 years, 1 month ago (2011-11-04 22:01:57 UTC) #3

http://codereview.chromium.org/8334031/diff/1/lib/isolate.cc
File lib/isolate.cc (right):

http://codereview.chromium.org/8334031/diff/1/lib/isolate.cc#newcode273
lib/isolate.cc:273: spawned_isolate->set_long_jump_base(NULL);
On 2011/11/04 17:24:42, Ivan Posva wrote:
> Why not resetting it to the original value here? I know that for now this is
> NULL, but what if it changes?

Done.

http://codereview.chromium.org/8334031/diff/1/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8334031/diff/1/vm/dart_api_impl.cc#newcode92
vm/dart_api_impl.cc:92: isolate->set_long_jump_base(NULL);
On 2011/11/04 17:24:42, Ivan Posva wrote:
> ditto.

Done.

http://codereview.chromium.org/8334031/diff/1/vm/unit_test.h
File vm/unit_test.h (right):

http://codereview.chromium.org/8334031/diff/1/vm/unit_test.h#newcode176
vm/unit_test.h:176: isolate_ = Dart::CreateIsolate();
Good point, simplifies stuff a lot.

On 2011/11/04 17:24:42, Ivan Posva wrote:
> Why not just use the Dart_CreateIsolate call here instead of the internal
calls?

http://codereview.chromium.org/8334031/diff/1/vm/unit_test.h#newcode192
vm/unit_test.h:192: Dart::ShutdownIsolate();
On 2011/11/04 17:24:42, Ivan Posva wrote:
> In the same way we should just call the Dart API entry here.

Done.

Expand Messages | Collapse Messages