Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 8334015: Fix test to use developer mode. DartC does not have to check arguments to native methods. (Closed)

Created:
9 years, 2 months ago by ngeoffray
Modified:
9 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix test to use developer mode. DartC does not have to check arguments to native methods.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -45 lines) Patch
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/src/MathTest.dart View 1 1 chunk +0 lines, -41 lines 0 comments Download
A + tests/language/src/MathVMTest.dart View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
9 years, 2 months ago (2011-10-18 09:05:54 UTC) #1
floitsch
Doesn't that remove the test, that the VM catches the error in unchecked mode?
9 years, 2 months ago (2011-10-18 09:11:00 UTC) #2
ngeoffray
On 2011/10/18 09:11:00, floitsch wrote: > Doesn't that remove the test, that the VM catches ...
9 years, 2 months ago (2011-10-18 09:15:03 UTC) #3
floitsch
9 years, 2 months ago (2011-10-18 09:18:48 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698