Issue 8333016: Migrate --expose_core_impl flag from DartRunner to DartCompiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8333016: Migrate --expose_core_impl flag from DartRunner to DartCompiler. (Closed)

Created:
9 years, 2 months ago by zundel

Modified:
9 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Migrate --expose_core_impl flag from DartRunner to DartCompiler. R=ngeoffray BUG=527517 Committed: https://code.google.com/p/dart/source/detail?r=553

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -65 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	7 chunks	+58 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/runner/DartRunner.java	View	3 chunks	+0 lines, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

Its a small change, but does anyone know if this is still needed?

9 years, 2 months ago (2011-10-19 13:23:04 UTC) #1

ngeoffray

9 years, 2 months ago (2011-10-19 13:47:11 UTC) #2

LGTM!

I think moving it is fine right now. The VM may just remove the option, because
it just duplicates #import("dart:coreimpl"), in theory. They also use the option
to disable privacy, and may rename it to be more specific. We could then change
the flag.

Expand Messages | Collapse Messages