Issue 8332024: Add a test for http://code.google.com/p/dart/issues/detail?id=223.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8332024: Add a test for http://code.google.com/p/dart/issues/detail?id=223. (Closed)

Created:
9 years, 2 months ago by ngeoffray

Modified:
9 years, 2 months ago

Reviewers:
mmendez, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Add a test for http://code.google.com/p/dart/issues/detail?id=223. Committed: https://code.google.com/p/dart/source/detail?r=679

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	tests/language/language.status	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	A	tests/language/src/FactoryArrowTest.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. http://codereview.chromium.org/8332024/diff/1/tests/language/src/FactoryArrowTest.dart File tests/language/src/FactoryArrowTest.dart (right): http://codereview.chromium.org/8332024/diff/1/tests/language/src/FactoryArrowTest.dart#newcode11 tests/language/src/FactoryArrowTest.dart:11: Expect.isTrue(new A() is A); Indent one more.

9 years, 2 months ago (2011-10-25 08:27:55 UTC) #2

ngeoffray

9 years, 2 months ago (2011-10-25 08:33:00 UTC) #3

Thanks,

http://codereview.chromium.org/8332024/diff/1/tests/language/src/FactoryArrow...
File tests/language/src/FactoryArrowTest.dart (right):

http://codereview.chromium.org/8332024/diff/1/tests/language/src/FactoryArrow...
tests/language/src/FactoryArrowTest.dart:11: Expect.isTrue(new A() is A);
On 2011/10/25 08:27:56, kasperl wrote:
> Indent one more.

Done. I'd like to say I left it here on purpose... :) Nice catch

Expand Messages | Collapse Messages

Issue 8332024: Add a test for http://code.google.com/p/dart/issues/detail?id=223. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages