Issue 8330003: Rename cloneNode to clone and move it into the Node interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8330003: Rename cloneNode to clone and move it into the Node interface. (Closed)

Created:
9 years, 2 months ago by nweiz

Modified:
9 years, 2 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Rename cloneNode to clone and move it into the Node interface. Committed: https://code.google.com/p/dart/source/detail?r=563

Patch Set 2 : Don't change the benchmark that uses the DOM interface. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	client/html/benchmarks/dromaeo/tests/DomModify.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	client/html/release/html.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	client/html/src/Node.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/html/src/NodeWrappingImplementation.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

http://codereview.chromium.org/8330003/diff/1/client/dom/benchmarks/dromaeo/tests/dom-modify.dart File client/dom/benchmarks/dromaeo/tests/dom-modify.dart (left): http://codereview.chromium.org/8330003/diff/1/client/dom/benchmarks/dromaeo/tests/dom-modify.dart#oldcode51 client/dom/benchmarks/dromaeo/tests/dom-modify.dart:51: for (int i = 0; i < elems.length; i++) ...

9 years, 2 months ago (2011-10-18 01:36:48 UTC) #2

nweiz

9 years, 2 months ago (2011-10-18 19:49:41 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 8330003: Rename cloneNode to clone and move it into the Node interface. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Don't change the benchmark that uses the DOM interface. #

Messages