Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 8321024: Clean up (most) uses of Array. Still more to come in the VM corelib code base. (Closed)

Created:
9 years, 2 months ago by ngeoffray
Modified:
9 years, 2 months ago
Reviewers:
mmendez, floitsch, srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up (most) uses of Array. Still more to come in the VM corelib code base. Committed: https://code.google.com/p/dart/source/detail?r=507

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -232 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/lib/corelib_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/lib/implementation/array.dart View 14 chunks +37 lines, -79 lines 0 comments Download
M compiler/lib/implementation/array.js View 2 chunks +7 lines, -13 lines 0 comments Download
M compiler/lib/implementation/arrays.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M compiler/lib/implementation/isolate.js View 1 chunk +1 line, -1 line 0 comments Download
M compiler/lib/implementation/regexp.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/lib/implementation/string.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M compiler/lib/implementation/string.js View 1 chunk +1 line, -1 line 0 comments Download
M compiler/lib/implementation/string_base.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M compiler/lib/implementation/string_buffer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D corelib/src/implementation/array.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M corelib/src/implementation/corelib_impl_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M corelib/src/implementation/future_implementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M corelib/src/implementation/hash_map_set.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/lib/array.dart View 1 1 chunk +2 lines, -28 lines 0 comments Download
M runtime/lib/arrays.dart View 1 5 chunks +13 lines, -12 lines 0 comments Download
M runtime/lib/growable_array.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/immutable_map.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/lib/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/regexp.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string.dart View 9 chunks +30 lines, -30 lines 0 comments Download
M runtime/lib/string_buffer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/corelib/src/GrowableObjectArray2VMTest.dart View 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ngeoffray
9 years, 2 months ago (2011-10-17 21:52:44 UTC) #1
ngeoffray
+srdjan, +mmendez
9 years, 2 months ago (2011-10-18 07:45:08 UTC) #2
srdjan
DBC http://codereview.chromium.org/8321024/diff/2001/runtime/lib/array.dart File runtime/lib/array.dart (right): http://codereview.chromium.org/8321024/diff/2001/runtime/lib/array.dart#newcode5 runtime/lib/array.dart:5: interface Array<T> extends List<T> { If this is ...
9 years, 2 months ago (2011-10-18 08:08:20 UTC) #3
srdjan
LGTM for VM core library changes. On 2011/10/18 08:08:20, srdjan wrote: > DBC > > ...
9 years, 2 months ago (2011-10-18 08:08:38 UTC) #4
ngeoffray
Thanks Srdjan http://codereview.chromium.org/8321024/diff/2001/runtime/lib/array.dart File runtime/lib/array.dart (right): http://codereview.chromium.org/8321024/diff/2001/runtime/lib/array.dart#newcode5 runtime/lib/array.dart:5: interface Array<T> extends List<T> { On 2011/10/18 ...
9 years, 2 months ago (2011-10-18 08:15:01 UTC) #5
floitsch
9 years, 2 months ago (2011-10-18 09:34:33 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld 408576698