Issue 8320002: Add test for blacklisting extension/implementation of classes and interfaces. Added a few tests, ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8320002: Add test for blacklisting extension/implementation of classes and interfaces. Added a few tests, ... (Closed)

Created:
9 years, 2 months ago by srdjan

Modified:
9 years, 2 months ago

Reviewers:
gbracha

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Add test for blacklisting extension/implementation of classes and interfaces. Added a few tests, please comment which additional ones need to be added. Committed: https://code.google.com/p/dart/source/detail?r=481

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
	M	tests/language/language.status	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download
	A	tests/language/src/BlackListedTest.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gbracha

9 years, 2 months ago (2011-10-17 17:45:40 UTC) #2

LGTM, modulo the comment that String may become implementable down the line.

http://codereview.chromium.org/8320002/diff/1/tests/language/src/BlackListedT...
File tests/language/src/BlackListedTest.dart (right):

http://codereview.chromium.org/8320002/diff/1/tests/language/src/BlackListedT...
tests/language/src/BlackListedTest.dart:26: class MyString implements String {} 
          /// 09: compile-time error
I suspect we may change this in the foreseeable future. People may have a real
need to create different subtypes of String. bUt for now we're ok.

Expand Messages | Collapse Messages