Issue 8319020: Verify method overrides in checked mode only (fix issue 69).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8319020: Verify method overrides in checked mode only (fix issue 69). (Closed)

Created:
9 years, 2 months ago by regis

Modified:
9 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Verify method overrides in checked mode only (fix issue 69). Committed: https://code.google.com/p/dart/source/detail?r=489

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -33 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	2 chunks	+36 lines, -28 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	tests/language/src/ClassOverrideNegativeTest.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM. http://codereview.chromium.org/8319020/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): http://codereview.chromium.org/8319020/diff/1/runtime/vm/class_finalizer.cc#newcode162 runtime/vm/class_finalizer.cc:162: OS::Print("The type of the instance method '%s' in ...

9 years, 2 months ago (2011-10-17 22:56:26 UTC) #2

regis

9 years, 2 months ago (2011-10-17 22:59:13 UTC) #3

Thanks!

http://codereview.chromium.org/8319020/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

http://codereview.chromium.org/8319020/diff/1/runtime/vm/class_finalizer.cc#n...
runtime/vm/class_finalizer.cc:162: OS::Print("The type of the instance method
'%s' in class '%s' is not a "
On 2011/10/17 22:56:26, hausner wrote:
> Can probably save a word:
> 
> The type of the instance ... -> The type of instance ...

Done.

http://codereview.chromium.org/8319020/diff/1/runtime/vm/class_finalizer.cc#n...
runtime/vm/class_finalizer.cc:842: ReportError("The type of the instance method
'%s' in class '%s' is "
On 2011/10/17 22:56:26, hausner wrote:
> ditto

Done.

Expand Messages | Collapse Messages

Issue 8319020: Verify method overrides in checked mode only (fix issue 69). (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages