Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 8318012: Disable DoubleCompareTest in release mode. (Closed)

Created:
9 years, 2 months ago by floitsch
Modified:
9 years, 2 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable DoubleCompareTest in release mode. TBR=ngeoffray R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=472

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/corelib/corelib.status View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
floitsch
9 years, 2 months ago (2011-10-17 16:42:12 UTC) #1
ngeoffray
LGTM
9 years, 2 months ago (2011-10-17 16:49:44 UTC) #2
ngeoffray
9 years, 2 months ago (2011-10-17 16:50:41 UTC) #3
http://codereview.chromium.org/8318012/diff/1/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

http://codereview.chromium.org/8318012/diff/1/tests/corelib/corelib.status#ne...
tests/corelib/corelib.status:24: [ $arch == dartc || $mode == release ]
|| => && ?

Powered by Google App Engine
This is Rietveld 408576698