Issue 8318002: Fix 5442338: Return true if the pc descriptor verifier skips verification because of too many des...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8318002: Fix 5442338: Return true if the pc descriptor verifier skips verification because of too many des... (Closed)

Created:
9 years, 2 months ago by srdjan

Modified:
9 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix 5442338: Return true if the pc descriptor verifier skips verification because of too many descriptors to check. Committed: https://code.google.com/p/dart/source/detail?r=466

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	runtime/vm/code_generator_ia32.cc	View		2 chunks	+3 lines, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/8318002/diff/3001/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): http://codereview.chromium.org/8318002/diff/3001/runtime/vm/code_generator_ia32.cc#newcode364 runtime/vm/code_generator_ia32.cc:364: return true; Do you actually need the return ...

9 years, 2 months ago (2011-10-17 12:19:04 UTC) #2

srdjan

9 years, 2 months ago (2011-10-17 12:23:48 UTC) #3

http://codereview.chromium.org/8318002/diff/3001/runtime/vm/code_generator_ia...
File runtime/vm/code_generator_ia32.cc (right):

http://codereview.chromium.org/8318002/diff/3001/runtime/vm/code_generator_ia...
runtime/vm/code_generator_ia32.cc:364: return true;
On 2011/10/17 12:19:04, ngeoffray wrote:
> Do you actually need the return now that the method always returns true? Will
> you improve the method in a way that you know will return false?

Remove return, use ASSERTS as already implemented.

Expand Messages | Collapse Messages

Issue 8318002: Fix 5442338: Return true if the pc descriptor verifier skips verification because of too many des... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages