Issue 8317008: Implement compareTo on DartC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8317008: Implement compareTo on DartC. (Closed)

Created:
9 years, 2 months ago by floitsch

Modified:
9 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, mmendez

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Implement compareTo on DartC. BUG=5427706 Committed: https://code.google.com/p/dart/source/detail?r=470

Patch Set 2 : Remove commented line. #

Total comments: 2

Patch Set 3 : Address comments. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -5 lines)			Patch
	M	compiler/lib/implementation/number.dart	View	1 2	1 chunk	+26 lines, -4 lines	0 comments	Download
	M	tests/corelib/corelib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! http://codereview.chromium.org/8317008/diff/1001/compiler/lib/implementation/number.dart File compiler/lib/implementation/number.dart (right): http://codereview.chromium.org/8317008/diff/1001/compiler/lib/implementation/number.dart#newcode37 compiler/lib/implementation/number.dart:37: // Don't use the 'this'-object, but get the ...

9 years, 2 months ago (2011-10-17 15:59:07 UTC) #2

floitsch

9 years, 2 months ago (2011-10-17 16:06:40 UTC) #3

http://codereview.chromium.org/8317008/diff/1001/compiler/lib/implementation/...
File compiler/lib/implementation/number.dart (right):

http://codereview.chromium.org/8317008/diff/1001/compiler/lib/implementation/...
compiler/lib/implementation/number.dart:37: // Don't use the 'this'-object, but
get the native JS number.
On 2011/10/17 15:59:07, ngeoffray wrote:
> That's the call to 'toDouble'? Could you be explicit in the comment? Also
remove
> the '-', it's quite overloaded inside this function...

Done.