Issue 8317004: DartC: Replace Array by List in the type-checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8317004: DartC: Replace Array by List in the type-checker. (Closed)

Created:
9 years, 2 months ago by karlklose

Modified:
9 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

DartC: Replace Array by List in the type-checker. Committed: https://code.google.com/p/dart/source/detail?r=505

Patch Set 1 #

Total comments: 4

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -60 lines)			Patch
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	5 chunks	+18 lines, -18 lines	4 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeTest.java	View	2 chunks	+17 lines, -33 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java	View	2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM http://codereview.chromium.org/8317004/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java (left): http://codereview.chromium.org/8317004/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java#oldcode192 compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java:192: final String header = "{ ClassWithMethods c; int ...

9 years, 2 months ago (2011-10-17 14:27:06 UTC) #2

karlklose

9 years, 2 months ago (2011-10-18 07:52:52 UTC) #3

http://codereview.chromium.org/8317004/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java
(left):

http://codereview.chromium.org/8317004/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java:192:
final String header = "{ ClassWithMethods c; int i, j; Array array; ";
No, it is not used.

http://codereview.chromium.org/8317004/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java:227:
final String header = "{ ClassWithMethods c; Array array; ";
It was also not used here.

Expand Messages | Collapse Messages