Issue 8304012: Addresses issue 10.

http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dart/compiler/ast/DartNode.java File compiler/java/com/google/dart/compiler/ast/DartNode.java (right): http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dart/compiler/ast/DartNode.java#newcode123 compiler/java/com/google/dart/compiler/ast/DartNode.java:123: node.setParent(this); How does this actually change anything?

9 years, 2 months ago (2011-10-15 00:01:05 UTC) #3

John Lenz

9 years, 2 months ago (2011-10-15 00:43:14 UTC) #4

jat

LGTM http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dart/compiler/ast/DartNode.java File compiler/java/com/google/dart/compiler/ast/DartNode.java (right): http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dart/compiler/ast/DartNode.java#newcode123 compiler/java/com/google/dart/compiler/ast/DartNode.java:123: node.setParent(this); On 2011/10/15 00:43:14, John Lenz wrote: > ...

9 years, 2 months ago (2011-10-15 01:33:27 UTC) #5

John Lenz

9 years, 2 months ago (2011-10-17 18:34:41 UTC) #6

http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/ast/DartNode.java (right):

http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/ast/DartNode.java:123:
node.setParent(this);
On 2011/10/15 00:01:05, jat wrote:
> How does this actually change anything?

See:
http://www.oracle.com/technetwork/java/javase/compatibility-417013.html#incom...
(search for "Compiler No Longer Allows Access to Private Members of Type
Variables").

http://codereview.chromium.org/8304012/diff/2001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/ast/DartNode.java:123:
node.setParent(this);
On 2011/10/15 01:33:27, jat wrote:
> On 2011/10/15 00:43:14, John Lenz wrote:
> > On 2011/10/15 00:01:05, jat wrote:
> > > How does this actually change anything?
> > 
> > See:
> >
>
http://www.oracle.com/technetwork/java/javase/compatibility-417013.html#incom...
> > (search for "Compiler No Longer Allows Access to Private Members of Type
> > Variables").
> 
> Please add a comment explaining why this is here -- otherwise someone may undo
> the change in the future.

Done.

Expand Messages | Collapse Messages

Issue 8304012: Addresses issue 10. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages