Issue 8301002: Namespace named parameters to avoid conflicts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8301002: Namespace named parameters to avoid conflicts (Closed)

Created:
9 years, 2 months ago by John Lenz

Modified:
9 years, 2 months ago

Reviewers:
jgw

CC:
reviews_dartlang.org, sra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Namespace named parameters to avoid conflicts Committed: https://code.google.com/p/dart/source/detail?r=480

Patch Set 1 : '' #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java	View		4 chunks	+17 lines, -4 lines	2 comments	Download
	M	tests/language/language.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jgw

LGTM, modulo naming comment. http://codereview.chromium.org/8301002/diff/2002/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java File compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java (right): http://codereview.chromium.org/8301002/diff/2002/compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java#newcode1262 compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1262: private String getPropNameForNameParameter(DartNamedExpression namedExpr) { ...

9 years, 2 months ago (2011-10-17 19:12:07 UTC) #3

John Lenz

9 years, 2 months ago (2011-10-17 19:19:39 UTC) #4

http://codereview.chromium.org/8301002/diff/2002/compiler/java/com/google/dar...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/8301002/diff/2002/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1262:
private String getPropNameForNameParameter(DartNamedExpression namedExpr) {
On 2011/10/17 19:12:07, jgw wrote:
> Name[d]Parameter?

Done.

Expand Messages | Collapse Messages