Issue 8295003: Improve error message for over qualified constructor names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8295003: Improve error message for over qualified constructor names. (Closed)

Created:
9 years, 2 months ago by John Lenz

Modified:
9 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Improve error message for over qualified constructor names. Committed: https://code.google.com/p/dart/source/detail?r=451

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -8 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java	View	5 chunks	+8 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ErrorMessageLocationTest.java	View	2 chunks	+23 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

John Lenz

On 2011/10/14 17:15:46, John Lenz wrote: This is the last place there is obviously missing ...

9 years, 2 months ago (2011-10-14 17:20:09 UTC) #2

Brian Wilkerson

9 years, 2 months ago (2011-10-14 17:29:57 UTC) #3

LGTM. It would be nice if we could catch missing code like this in a test...